PR review and merge process

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

PR review and merge process

Valery Yatsynovich
How can I find key persons who have permissions to review and merge pull requests?

There is no such information in https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md, but I think it could useful to have a list of key persons (possibly, divided by platforms) who can be contacted in person/mentioned directly in case if review of pull request is delayed or missed.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/4c2cfd1a-3f5e-4677-9f9d-7d125fc225e5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Simon Stewart
Hi,

Other than just looking at the list of commits around the area you're interested in and picking the person who's been most active?

Simon

On Fri, Feb 17, 2017 at 1:35 PM, Valery Yatsynovich <[hidden email]> wrote:
How can I find key persons who have permissions to review and merge pull requests?

There is no such information in https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md, but I think it could useful to have a list of key persons (possibly, divided by platforms) who can be contacted in person/mentioned directly in case if review of pull request is delayed or missed.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/4c2cfd1a-3f5e-4677-9f9d-7d125fc225e5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAOrAhYF-h2NzmqGJ2bgGMZSXjL5PrM7OMf3DLEPjs_YfoWHXzA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Valery Yatsynovich
Hi Simon,

It doesn't work, I've tried to act in this way. So I am thinking about other members who is not very active in development, but still may have time to review/merge. But I was not able to find  them.

Thanks,
Valery

On Wednesday, February 22, 2017 at 7:12:58 PM UTC+3, Simon Stewart wrote:
Hi,

Other than just looking at the list of commits around the area you're interested in and picking the person who's been most active?

Simon

On Fri, Feb 17, 2017 at 1:35 PM, Valery Yatsynovich <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="ElRA-gXzDgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">valeryya...@...> wrote:
How can I find key persons who have permissions to review and merge pull requests?

There is no such information in <a href="https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FSeleniumHQ%2Fselenium%2Fblob%2Fmaster%2FCONTRIBUTING.md\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGH-gl6y4S8MebTaa0eP8mHbu9XcA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2FSeleniumHQ%2Fselenium%2Fblob%2Fmaster%2FCONTRIBUTING.md\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNGH-gl6y4S8MebTaa0eP8mHbu9XcA&#39;;return true;">https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md, but I think it could useful to have a list of key persons (possibly, divided by platforms) who can be contacted in person/mentioned directly in case if review of pull request is delayed or missed.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="ElRA-gXzDgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">selenium-developers+unsubscribe@....
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/selenium-developers/4c2cfd1a-3f5e-4677-9f9d-7d125fc225e5%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/selenium-developers/4c2cfd1a-3f5e-4677-9f9d-7d125fc225e5%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/selenium-developers/4c2cfd1a-3f5e-4677-9f9d-7d125fc225e5%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/selenium-developers/4c2cfd1a-3f5e-4677-9f9d-7d125fc225e5%40googlegroups.com.
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/optout&#39;;return true;">https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/0c418436-53e6-46d1-a474-e845b7917d65%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Simon Stewart
Heh. I think people are either active in development or their doing something else entirely --- my experience is that those not committing code don't tend to review things. Maybe that'll change?

I do, however, believe that just asking for a review from someone on GitHub isn't enough. Lots of people don't check those notifications. A better bet is to hop on to IRC and ask someone to have a look at your PR, especially if it's just been sitting there for a while.

Kind regards,

Simon

On Wed, Feb 22, 2017 at 8:09 PM, Valery Yatsynovich <[hidden email]> wrote:
Hi Simon,

It doesn't work, I've tried to act in this way. So I am thinking about other members who is not very active in development, but still may have time to review/merge. But I was not able to find  them.

Thanks,
Valery

On Wednesday, February 22, 2017 at 7:12:58 PM UTC+3, Simon Stewart wrote:
Hi,

Other than just looking at the list of commits around the area you're interested in and picking the person who's been most active?

Simon

On Fri, Feb 17, 2017 at 1:35 PM, Valery Yatsynovich <[hidden email]> wrote:
How can I find key persons who have permissions to review and merge pull requests?

There is no such information in https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md, but I think it could useful to have a list of key persons (possibly, divided by platforms) who can be contacted in person/mentioned directly in case if review of pull request is delayed or missed.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to selenium-developers+unsubscrib[hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/4c2cfd1a-3f5e-4677-9f9d-7d125fc225e5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/0c418436-53e6-46d1-a474-e845b7917d65%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAOrAhYGW9si9oUX-tbU50JdzX%2BF8cuOjuEJtunENFbmPX%3D3rEw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Andreas Tolfsen
In reply to this post by Valery Yatsynovich
Valery Yatsynovich <[hidden email]> writes:

> It doesn't work, I've tried to act in this way. So I am thinking
> about other members who is not very active in development, but still
> may have time to review/merge. But I was not able to find them.

To find who does work in a certain area, it’s useful to look at the
blame or log for the particular file(s) you’re interested in,
irregardless which project you’re working on.  Of course it can be hard
to tie real names to GitHub nicknames, but it gives an idea who knows
enough about the code to review it.

Taking the blame log of the py/selenium/webdriver/firefox/options.py
file as example:

        % git blame py/selenium/webdriver/firefox/options.py
        …
        dfab9272978 (David Burns     2016-03-15 11:15:56 +0000  32) class Options(object):
        9706bb7525f (Andreas Tolfsen 2016-10-10 20:17:25 +0100  33)     KEY = "moz:firefoxOptions"
        dfab9272978 (David Burns     2016-03-15 11:15:56 +0000  34) 
        dfab9272978 (David Burns     2016-03-15 11:15:56 +0000  35)     def __init__(self):
        9706bb7525f (Andreas Tolfsen 2016-10-10 20:17:25 +0100  36)         self._binary = None
        0e5b18aa882 (Dave Hunt       2017-01-13 16:28:33 +0000  37)         self._preferences = {}
        dfab9272978 (David Burns     2016-03-15 11:15:56 +0000  38)         self._profile = None
        dfab9272978 (David Burns     2016-03-15 11:15:56 +0000  39)         self._arguments = []
        9706bb7525f (Andreas Tolfsen 2016-10-10 20:17:25 +0100  40)         self.log = Log()

Or the git log:

        % git shortlog py/selenium/webdriver/firefox/options.py
        Andreas Tolfsen (1):
              py: new FirefoxDriver ctor precedence logic and moz:firefoxOptions support (#2882)
       
        Daniel Davison (1):
              organize imports of firefox options; expanduser and abspath on chrome options extension (#3089)
       
        Dave Hunt (4):
              Avoid overriding capabilities with the defaults when using Firefox options
              Correct the expected capability name for the Firefox profile
              [py] Fix flake8 issues and run flake8 on Travis
              [py] Allow Firefox preferences to be set directly in Options
       
        David Burns (4):
              Adding Options object for use with Python FirefoxDriver
              Remove unneeded imports in Options module
              Pass in an encoded profile to the capabilities created from Options
              Move capabilities passed through to be only desiredCapabilities

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/1487854198.31320.2.camel%40mozilla.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Valery Yatsynovich
In reply to this post by Valery Yatsynovich
Hi Everyone,

Is there some good way to ask for review/merge pull-request in general?

I've tried 
 - pinging people via github
 - asking for review in IRC.
These options don't work for me.

Thanks,
Valery

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/859f777b-881b-4ce0-96e7-21d4e523b102%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Simon Stewart
Hi Valery,

I'm sorry you're not having much luck. It's not because we don't value your PR. On my side, it's because I want to take the time to do a proper review rather than something brief and rushed.

I've skimmed your PR when you asked on the IRC channel and it looks good, but at the time I was heads down in working on the W3C spec and fixing bugs that we'd encountered with some of our releases. Thanks to your diff, I've already done some clean up in ExpectedConditions. I'll take another look at it now.

Simon

On Wed, Mar 1, 2017 at 8:36 PM, Valery Yatsynovich <[hidden email]> wrote:
Hi Everyone,

Is there some good way to ask for review/merge pull-request in general?

I've tried 
 - pinging people via github
 - asking for review in IRC.
These options don't work for me.

Thanks,
Valery

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/859f777b-881b-4ce0-96e7-21d4e523b102%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAOrAhYGH9nfGkBU74xJd_eJj4%2BJ3tY8xZe4Z45aO0ofo6n-6AA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Valery Yatsynovich
Hi Simon,

Thank you for your explanation and thank you for merging PR.

To summarize:
 - find active people by commits and try them pinging via github
 - use IRC to request for review
 - be patient :)

Thanks,
Valery

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/e6a529aa-5b50-439a-9f3d-982badae517a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: PR review and merge process

Simon Stewart
In essence, that's correct. There are some other project members who are significantly better at checking GitHub for PRs to review than I am, so sometimes the active people find you :)

Thank you for being patient, and thank you for the PR!

Simon

On Sun, Mar 5, 2017 at 6:19 PM, Valery Yatsynovich <[hidden email]> wrote:
Hi Simon,

Thank you for your explanation and thank you for merging PR.

To summarize:
 - find active people by commits and try them pinging via github
 - use IRC to request for review
 - be patient :)

Thanks,
Valery

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/e6a529aa-5b50-439a-9f3d-982badae517a%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Selenium Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/selenium-developers/CAOrAhYEmEkNtiT3nxTaz%3DTRh6B9ToO%2B%3D%3D%2BPjD15YXRe7Zg%2BV7g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.